Add strict to modules shared to the PG safe zone in pg_config.dist.yml
#995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yml.
Versions of Perl prior to 5.34 need this. Otherwise warnings are issue
by the `BEGIN { strict->import }` approach now used in place of the old
`BEGIN { be_strict() }` approach.
Note that this is not used by webwork2, but the standalone renderer will
need this (if anyone runs that with an older perl version). So the
standalone renderer will also need to update its distributed
pg_config.yml file.
Also change `Main` to `main` in the translator. I can't resist fixing
this any longer. The proper namespace is `main`. This is also used
inconsistently in `Translator.pm`. Other than these two instances
`main` is used everywhere else.
pstaabp
approved these changes
Jan 31, 2024
drdrew42
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of Perl prior to 5.34 need this. Otherwise warnings are issue by the
BEGIN { strict->import }approach now used in place of the oldBEGIN { be_strict() }approach.Note that this is not used by webwork2, but the standalone renderer will need this (if anyone runs that with an older perl version). So the standalone renderer will also need to update its distributed pg_config.yml file.
Also change
Maintomainin the translator. I can't resist fixing this any longer. The proper namespace ismain. This is also used inconsistently inTranslator.pm. Other than these two instancesmainis used everywhere else.This is related to (but not needed to fix) the issue brought up in #968 (comment).