more efficient database accessing

Co-authored-by: Glenn Rice <47527406+drgrice1@users.noreply.github.com>
openwebwork · Dec 18, 2024 · e34631c · e34631c
1 parent f455e39
commit e34631c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/lib/WeBWorK/AchievementItems/ExtendDueDate.pm b/lib/WeBWorK/AchievementItems/ExtendDueDate.pm
@@ -79,9 +79,7 @@ sub use_item ($self, $userName, $c) {
 
 	# Change the seed for all of the problems if the set is currently closed.
 	if (after($set->due_date)) {
-		my @probIDs = $db->listUserProblems($userName, $setID);
-		for my $probID (@probIDs) {
-			my $problem = $db->getUserProblem($userName, $setID, $probID);
+		for my $problem ($db->getUserProblemsWhere({ user_id => $userName, set_id => $setID })) {
 			$problem->problem_seed($problem->problem_seed % 2**31 + 1);
 			$db->putUserProblem($problem);
 		}

diff --git a/lib/WeBWorK/AchievementItems/ReducedCred.pm b/lib/WeBWorK/AchievementItems/ReducedCred.pm
@@ -85,9 +85,7 @@ sub use_item ($self, $userName, $c) {
 
 	# Change the seed for all of the problems if the set is currently closed.
 	if (after($set->due_date)) {
-		my @probIDs = $db->listUserProblems($userName, $setID);
-		for my $probID (@probIDs) {
-			my $problem = $db->getUserProblem($userName, $setID, $probID);
+		for my $problem ($db->getUserProblemsWhere({ user_id => $userName, set_id => $setID })) {
 			$problem->problem_seed($problem->problem_seed % 2**31 + 1);
 			$db->putUserProblem($problem);
 		}

diff --git a/lib/WeBWorK/AchievementItems/SuperExtendDueDate.pm b/lib/WeBWorK/AchievementItems/SuperExtendDueDate.pm
@@ -79,9 +79,7 @@ sub use_item ($self, $userName, $c) {
 
 	# Change the seed for all of the problems if the set is currently closed.
 	if (after($set->due_date)) {
-		my @probIDs = $db->listUserProblems($userName, $setID);
-		for my $probID (@probIDs) {
-			my $problem = $db->getUserProblem($userName, $setID, $probID);
+		for my $problem ($db->getUserProblemsWhere({ user_id => $userName, set_id => $setID })) {
 			$problem->problem_seed($problem->problem_seed % 2**31 + 1);
 			$db->putUserProblem($problem);
 		}