This repository has been archived by the owner on Jul 9, 2020. It is now read-only.
Fullscreen mode for advanced json editor #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
reviewed
Mar 10, 2017
There was a problem hiding this comment.
I left you a formal review for style issues.
Could you please also squash the commits into one?
Try to use a commit message like the following:
[prefix] Past tense verb of action completed
Example:
[admin] Added full screen to advanced mode #41
Implements and closes #41
I will test the the feature asap.
| @@ -21,6 +26,10 @@ | |||
| fontSize: 14, | |||
| showInvisibles: true | |||
| }); | |||
|
|
|||
| //add listener to .screen-mode button for toggleScreenMode | |||
There was a problem hiding this comment.
leave a space after //:
// add listener to .screen-mode button for toggleScreenMode
| var initAdvancedEditor = function(target, data, schema){ | ||
|
|
There was a problem hiding this comment.
remove blank line for consistency with the rest of the code (increase line-height in your editor if you think lines are too close together)
| @@ -21,6 +26,10 @@ | |||
| fontSize: 14, | |||
| showInvisibles: true | |||
| }); | |||
|
|
|||
| @@ -21,6 +26,10 @@ | |||
| fontSize: 14, | |||
| showInvisibles: true | |||
| }); | |||
|
|
|||
| //add listener to .screen-mode button for toggleScreenMode | |||
|
|
|||
|
|
||
| //set the advanced editor container to full screen mode | ||
| toggleFullScreen(); | ||
|
|
There was a problem hiding this comment.
same here, these blank lines are not needed, the code is readable enough to be understood without them
|
Okay, noted, I'll follow those standards
…On 10 March 2017 at 14:08, Federico Capoano ***@***.***> wrote:
***@***.**** commented on this pull request.
I left you a formal review for style issues.
Could you please also squash the commits into one?
Try to use a commit message like the following:
[prefix] Past tense verb of action completed
Example:
[admin] Added full screen to advanced mode
I will test the the feature asap.
------------------------------
In django_netjsonconfig/static/django-netjsonconfig/js/widget.js
<#42 (comment)>
:
> @@ -21,6 +26,10 @@
fontSize: 14,
showInvisibles: true
});
+
+ //add listener to .screen-mode button for toggleScreenMode
leave a space after //:
// add listener to .screen-mode button for toggleScreenMode
------------------------------
In django_netjsonconfig/static/django-netjsonconfig/js/widget.js
<#42 (comment)>
:
> var initAdvancedEditor = function(target, data, schema){
+
remove blank line for consistency with the rest of the code (increase
line-height in your editor if you think lines are too close together)
------------------------------
In django_netjsonconfig/static/django-netjsonconfig/js/widget.js
<#42 (comment)>
:
> @@ -21,6 +26,10 @@
fontSize: 14,
showInvisibles: true
});
+
remove this blank line too
------------------------------
In django_netjsonconfig/static/django-netjsonconfig/js/widget.js
<#42 (comment)>
:
> @@ -21,6 +26,10 @@
fontSize: 14,
showInvisibles: true
});
+
+ //add listener to .screen-mode button for toggleScreenMode
+
same here
------------------------------
In django_netjsonconfig/static/django-netjsonconfig/js/widget.js
<#42 (comment)>
:
> @@ -117,6 +126,10 @@
header.find('.advanced-mode').click(function(){
// update autogenrated advanced json editor with new data
advanced_editor.set(JSON.parse(field.val()));
+
+ //set the advanced editor container to full screen mode
+ toggleFullScreen();
+
same here, these blank lines are not needed, the code is readable enough
to be understood without them
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALaC4Jt7cVrCIS1U9Sn1smTF326sQhsyks5rkUtDgaJpZM4MZRnV>
.
|
1 similar comment
Show template name instead of config name (more useful).
Allows applying the admin theme for the frontend.
Added syntax highlighting, line numbers and other nice features via the ace json editor Closes #40 (commits were squashed and merged manually).
- switched default theme to a dark theme - set indentation to 4 spaces - set font size to 14px - show invisibles - allow only 'code' mode (less is more)
|
Read a guide on how to use git rebase interactive to learn to squash your commits into one. |
|
Pay attention, you are including commits that are already on master, please fix it, I suggest you to start from a clean master branch |
|
okay, let me do so now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #41
I have added the full screen mode to the advanced json editor added lately. So one can toggle full screen mode on and off easily now.