Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify tool configuration in pyproject.toml #1028

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Unify tool configuration in pyproject.toml #1028

merged 5 commits into from
Jan 19, 2023

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Jan 18, 2023

Closes #1027

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Base: 52.56% // Head: 38.95% // Decreases project coverage by -13.62% ⚠️

Coverage data is based on head (bd9cffd) compared to base (e58748f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1028       +/-   ##
===========================================
- Coverage   52.56%   38.95%   -13.62%     
===========================================
  Files          34       34               
  Lines        3394     3394               
===========================================
- Hits         1784     1322      -462     
- Misses       1610     2072      +462     
Impacted Files Coverage Δ
openwpm/storage/in_memory_storage.py 35.63% <0.00%> (-62.07%) ⬇️
openwpm/storage/arrow_storage.py 30.23% <0.00%> (-59.31%) ⬇️
openwpm/commands/profile_commands.py 30.18% <0.00%> (-50.95%) ⬇️
openwpm/storage/sql_provider.py 40.57% <0.00%> (-46.38%) ⬇️
openwpm/storage/local_storage.py 48.38% <0.00%> (-45.17%) ⬇️
openwpm/errors.py 61.90% <0.00%> (-38.10%) ⬇️
openwpm/storage/leveldb.py 55.17% <0.00%> (-34.49%) ⬇️
openwpm/socket_interface.py 29.80% <0.00%> (-29.14%) ⬇️
openwpm/browser_manager.py 46.23% <0.00%> (-28.65%) ⬇️
openwpm/utilities/db_utils.py 76.66% <0.00%> (-20.00%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@englehardt englehardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wasn't aware of this file type before. Glad to see it unified.

@vringar vringar merged commit 5e0c44b into master Jan 19, 2023
@vringar vringar deleted the pyproject_toml branch January 19, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pyproject.toml and fix coverage
3 participants