Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): always enable extension #1100

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Aug 6, 2024

We are already asserting that the extension socket exists unconditionally here:

# passes "READY" to the TaskManager to signal a successful startup
self.status_queue.put(("STATUS", "Browser Ready", "READY"))
self.browser_params.profile_path = browser_profile_path
assert extension_socket is not None
# starts accepting arguments until told to die
while True:
# no command for now -> sleep to avoid pegging CPU on blocking get
if self.command_queue.empty():
time.sleep(0.001)

so noone could have used OpenWPM with the extension disabled

@vringar vringar enabled auto-merge (rebase) August 6, 2024 15:59
@vringar vringar merged commit d1a60fb into master Aug 6, 2024
19 checks passed
@vringar vringar deleted the refactor/always-on-extension branch August 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant