-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor yurtadm join #1049
refactor yurtadm join #1049
Conversation
@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
+ Coverage 49.46% 50.04% +0.57%
==========================================
Files 96 96
Lines 13056 12841 -215
==========================================
- Hits 6458 6426 -32
+ Misses 6061 5879 -182
+ Partials 537 536 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
50d6a24
to
6031a15
Compare
@Congrool @donychen1134 PTAL |
please use the official link: https://dl.k8s.io/release/${RELEASE}/bin/linux/${ARCH}/{kubeadm,kubelet} to download kubelet and kubeadm binary files. reference link: https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/ |
@YTGhost how about make pkg/yurtadm/util folder more clearly in Yurtadm join refactor. |
d86c956
to
e8df464
Compare
@rambohe-ch PTAL |
Signed-off-by: HIHIA <283304489@qq.com>
e8df464
to
73b3903
Compare
@rambohe-ch PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, YTGhost The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: HIHIA 283304489@qq.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #889
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note