Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor yurtadm join #1049

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Nov 8, 2022

Signed-off-by: HIHIA 283304489@qq.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #889

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: HIHIA 283304489@qq.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #889

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1049 (73b3903) into master (c3a7eaa) will increase coverage by 0.57%.
The diff coverage is 51.72%.

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
+ Coverage   49.46%   50.04%   +0.57%     
==========================================
  Files          96       96              
  Lines       13056    12841     -215     
==========================================
- Hits         6458     6426      -32     
+ Misses       6061     5879     -182     
+ Partials      537      536       -1     
Flag Coverage Δ
unittests 50.04% <51.72%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/util/kubernetes/kubeadm/app/preflight/checks.go 0.00% <ø> (ø)
...bernetes/kubeadm/app/util/apiclient/idempotency.go 24.81% <ø> (+8.94%) ⬆️
...ubernetes/kubeadm/app/util/runtime/runtime_unix.go 100.00% <ø> (ø)
pkg/yurtadm/util/pubkeypin/pubkeypin.go 77.55% <ø> (ø)
pkg/yurtadm/util/edgenode/edgenode.go 9.02% <16.66%> (ø)
pkg/yurtadm/util/kubeconfig/kubeconfig.go 55.76% <55.76%> (ø)
pkg/util/iptables/iptables.go 87.67% <0.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YTGhost YTGhost force-pushed the refactor-yurtadm-join branch 4 times, most recently from 50d6a24 to 6031a15 Compare November 8, 2022 15:37
@rambohe-ch
Copy link
Member

@Congrool @donychen1134 PTAL

pkg/yurtadm/cmd/cmd.go Outdated Show resolved Hide resolved
@rambohe-ch
Copy link
Member

please use the official link: https://dl.k8s.io/release/${RELEASE}/bin/linux/${ARCH}/{kubeadm,kubelet} to download kubelet and kubeadm binary files.

reference link: https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/

@rambohe-ch
Copy link
Member

@YTGhost how about make pkg/yurtadm/util folder more clearly in Yurtadm join refactor.

@YTGhost YTGhost force-pushed the refactor-yurtadm-join branch 3 times, most recently from d86c956 to e8df464 Compare November 15, 2022 15:36
@YTGhost
Copy link
Member Author

YTGhost commented Nov 15, 2022

@rambohe-ch PTAL

Signed-off-by: HIHIA <283304489@qq.com>
@YTGhost
Copy link
Member Author

YTGhost commented Nov 16, 2022

@rambohe-ch PTAL

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Nov 18, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]optimize yurtadm join command
3 participants