Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ota upgrade for static pod #1172

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

xavier-hou
Copy link
Member

Signed-off-by: hxcGit houxc_mail@163.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: hxcGit houxc_mail@163.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XL size/XL: 500-999 label Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #1172 (f5a0bad) into master (4b54ce8) will decrease coverage by 0.20%.
The diff coverage is 46.45%.

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
- Coverage   52.15%   51.96%   -0.20%     
==========================================
  Files         107      109       +2     
  Lines       13466    13520      +54     
==========================================
+ Hits         7023     7025       +2     
- Misses       5853     5903      +50     
- Partials      590      592       +2     
Flag Coverage Δ
unittests 51.96% <46.45%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/otaupdate/ota.go 43.51% <35.00%> (-14.01%) ⬇️
pkg/yurthub/otaupdate/upgrader/static_pod.go 37.50% <37.50%> (ø)
pkg/node-servant/static-pod-upgrade/upgrade.go 54.16% <56.41%> (-10.54%) ⬇️
pkg/yurthub/otaupdate/upgrader/daemon_pod.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xavier-hou xavier-hou force-pushed the ota-upgrade-static-pod branch 5 times, most recently from 6e64adb to 3080336 Compare January 29, 2023 14:34
Signed-off-by: hxcGit <houxc_mail@163.com>
Signed-off-by: hxcGit <houxc_mail@163.com>
Signed-off-by: hxcGit <houxc_mail@163.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, xavier-hou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Apr 17, 2023
@openyurt-bot openyurt-bot merged commit 727fa4c into openyurtio:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants