support pass bootstrap-file to yurthub #1333
Conversation
|
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@YTGhost PTAL |
|
Kudos, SonarCloud Quality Gate passed!
|
|
You have successfully added a new Trivy configuration |
|
You have successfully added a new Trivy configuration |
|
You have successfully added a new Trivy configuration |
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
- Coverage 53.28% 53.10% -0.19%
==========================================
Files 102 102
Lines 12776 12833 +57
==========================================
+ Hits 6808 6815 +7
- Misses 5413 5461 +48
- Partials 555 557 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| func (ycm *yurtHubCertManager) getBootstrapConfFile() string { | ||
| if len(ycm.bootstrapFile) != 0 { | ||
| return ycm.bootstrapFile | ||
| } |
There was a problem hiding this comment.
generateCertClientFn will invoke getBootstrapConfFile() function, dose it work well if yurthub restart and bootstrap file doesn't exist?
There was a problem hiding this comment.
yes, we need to use bootstrap file to apply certificates when certificates expired, so getBootstrapConfFile() is used in generateCertClientFn, and yurthub will always wait for bootstrap file until it is prepared by yurtadm renew certificate command.
|
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
bootstrap tokenon the edge node.--join-tokenis deprecated in yurthub, and plan to remove in OpenYurt version v1.5./v1/readyzendpoint for yurthub, add used by yurtadm command to check certificates are ready or not.Which issue(s) this PR fixes:
Fixes #1290
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note