【FIX】fix daemonset pod updater pointer error #1340
Conversation
|
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
You have successfully added a new Trivy configuration |
|
You have successfully added a new Trivy configuration |
|
You have successfully added a new Trivy configuration |
JameKeal
force-pushed
the
fix-daemonpodupdater-error
branch
from
dc64e43
to
cff087d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@xavier-hou PTAL |
Codecov Report
@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 52.96% 53.05% +0.09%
==========================================
Files 102 102
Lines 12849 12849
==========================================
+ Hits 6805 6817 +12
+ Misses 5486 5475 -11
+ Partials 558 557 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@JameKeal Thank you for your contribution~ |
|
@xavier-hou: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When i use helm to deploy application, the daemonset in helm charts is add annotations for daemonsetpodupdater to use, and containers are constantly being created and deleted after deploy.
I print some log for daemonsetpodupdater
and find some error
the code want to use pointer convert to string to compare
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note