-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use real kubernetes server address to yurthub when yurtadm join #1517
feat: use real kubernetes server address to yurthub when yurtadm join #1517
Conversation
@Lan-ce-lot: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
95ad8dd
to
6f60f36
Compare
Codecov Report
@@ Coverage Diff @@
## master #1517 +/- ##
==========================================
- Coverage 50.74% 50.38% -0.36%
==========================================
Files 131 132 +1
Lines 15576 15707 +131
==========================================
+ Hits 7904 7914 +10
- Misses 6951 7070 +119
- Partials 721 723 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6f60f36
to
c9abf2b
Compare
Signed-off-by: Lancelot <1984737645@qq.com>
c9abf2b
to
8f92b63
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Lan-ce-lot, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…openyurtio#1517) Signed-off-by: Lancelot <1984737645@qq.com>
What type of PR is this?
What this PR does / why we need it:
In the scenario where the user forgets to set the yurthub server address for the master node, the yurtadm join command should replace the yurthub parameter with the address obtained from the join.
Which issue(s) this PR fixes:
Fixes #
#1474
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note