-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix yurtstaticset workerpod reset error #1526
fix yurtstaticset workerpod reset error #1526
Conversation
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@xavier-hou PTAL |
Codecov Report
@@ Coverage Diff @@
## master #1526 +/- ##
=======================================
Coverage 50.42% 50.42%
=======================================
Files 132 132
Lines 15783 15784 +1
=======================================
+ Hits 7958 7959 +1
Misses 7094 7094
Partials 731 731
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JameKeal I think that it is a good idea to add name of yss for upgrade-worker pod. agree +1 |
/lgtm |
/backport release-v1.3 |
Successfully created backport PR for |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When user have more than one static pod want to upgrade, and the upgrade worker pod name has the same prefix in different yurtstaticset, when the upgradeinfo want to calculate information, it will confused.
So we need to add yurtstaticset name for worker pod to avoid this condition, and short for worker pod prefix to avoid the worker pod name is too long to make mistake
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note