enhancement: add tunnel server internal service in order to prevent x-tunnel-server-svc attached SLB to listen unsecure port #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
background:
x-tunnel-server-svc
) is used by yurt-tunnel-agent to connect yurt-tunnel-server. andx-tunnel-server-svc
service may be configured as NodePort type or LoadBalancer type for public network access.x-tunnel-server-svc
service type is LoadBalancer, the proxy ports inx-tunnel-service-svc
service will be listened by corresponding SLB(in public cloud. but listen internal port(9100) on public network will cause security risks.solution:
we can add a new service(type=ClusterIP) named
x-tunnel-server-internal-svc
for yurt-tunnel-server, sox-tunnel-server-svc
service is used for public network access, and newly added service is used for internal component(like prometheus/metrics server) access. and internal port mapping(like above 9100:10264) will only be added inx-tunnel-server-internal-svc
svc. so security risk can be solved.Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
make all
and make sure the yurt-tunnel can work with dns
Ⅴ. Special notes for reviews