Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix incomplete data copy of resource filter #452

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 6, 2021

Signed-off-by: SataQiu shidaqiu2018@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

// The copy built-in function copies elements from a source slice into a
// destination slice. (As a special case, it also will copy bytes from a
// string to a slice of bytes.) The source and destination may overlap. Copy
// returns the number of elements copied, which will be the minimum of
// len(src) and len(dst).
func copy(dst, src []Type) int

func (dr *filterReadCloser) Read(p []byte) (int, error) will return incomplete data when the data size is larger than the default size of p (32768).
The Read function can be called multi times, we should just use dr.data.Read(p) instead of copy.

Which issue(s) this PR fixes:

Fixes #426 #432

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

bugfix: fix incomplete data copy of resource filter

other Note

Signed-off-by: SataQiu <shidaqiu2018@gmail.com>
@rambohe-ch
Copy link
Member

@SataQiu Thank you for fixing this bug for specific case.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 6, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 6, 2021
@openyurt-bot openyurt-bot merged commit d4e2dff into openyurtio:master Sep 6, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Signed-off-by: SataQiu <shidaqiu2018@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] kubelet failed to list services through yurthub
3 participants