Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create to yurt-tunnel-server ClusterRole #500

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

adamzhoul
Copy link
Member

What type of PR is this?

/kind bug

Which issue(s) this PR fixes:

Fixes #498

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Sep 26, 2021
@rambohe-ch
Copy link
Member

@adamzhoul how about add create rights for config/setup/yurt-tunnel-server.yaml and config/yaml-template/yurt-tunnel-server.yaml?

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamzhoul, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 26, 2021
@openyurt-bot openyurt-bot merged commit a4e6de2 into openyurtio:master Sep 26, 2021
YRXING pushed a commit to YRXING/openyurt that referenced this pull request Oct 9, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Do we miss create for ClusterRole yurt-tunnel-server ?
3 participants