Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: reject delete pod request by yurthub when cloud-edge network disconnected #593

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind bug

What this PR does / why we need it:

when user deletes pod gracefully from cloud, kubelet need to remove pod from etcd forcefully after cleaning up pods info(like pod volume, network, containers etc.) on edge node. so yurthub need to forward delete pod request carefully as following:

  • If cloud-edge network disconnected, yurthub should reject delete pod request, so kubelet can retry to delete pod in next interval
  • when cloud-edge network recovered, delete pod request will be forwarded to kube-apiserver by yurthub.

so yurthub will return status code=403 for delete request when cloud-edge network disconnected.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind bug

What this PR does / why we need it:

when user deletes pod gracefully from cloud, kubelet need to remove pod from etcd forcefully after cleaning up pods info(like pod volume, network, containers etc.) on edge node. so yurthub need to forward delete pod request carefully as following:

  • If cloud-edge network disconnected, yurthub should reject delete pod request, so kubelet can retry to delete pod in next interval
  • when cloud-edge network recovered, delete pod request will be forwarded to kube-apiserver by yurthub.

so yurthub will return status code=403 for delete request when cloud-edge network disconnected.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added kind/bug kind/bug size/XS size/XS: 0-9 labels Nov 15, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member Author

/assign @Fei-Guo

@rambohe-ch
Copy link
Member Author

/assign @zyjhtangtang

@zyjhtangtang
Copy link
Contributor

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 22, 2021
@openyurt-bot openyurt-bot merged commit dc06b31 into master Nov 22, 2021
@rambohe-ch rambohe-ch deleted the reject-delete-pod-request branch January 12, 2022 06:19
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants