Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] enable yurthub to handle upgrade request #673

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

Congrool
Copy link
Member

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Since APIServer can handle websocket request, yurthub which is serving as a proxy server for kubelet and other components should have the capability of proxying websocket traffic to APIServer.

Which issue(s) this PR fixes:

Fixes #562

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@Congrool
Copy link
Member Author

I've rerun the failed conformance cases in #562, and all cases passed.
image

Here's also some websocket request logs.

WSAPISERVER=wss://169.254.2.1:10268
SECRET_NAME=log-exporter-sa-token-jkqlt
TOKEN=$(kubectl get secret $SECRET_NAME -o jsonpath='{.data.token}' | base64 --decode)
wscat -n -c $WSAPISERVER/api/v1/namespaces/kube-system/pods/yurt-tunnel-agent-cssqz/log?container=yurt-tunnel-agent --header "Authorization: Bearer $TOKEN"

image

We can see that the proxy of websocket request succeeded.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

@Congrool Based on this pull request, kubectl exec can work or not through yurthub?

@openyurt-bot openyurt-bot added the approved approved label Dec 11, 2021
@rambohe-ch
Copy link
Member

/hold

@openyurt-bot openyurt-bot added the do-not-merge/hold do-not-merge/hold label Dec 11, 2021
@Congrool
Copy link
Member Author

Congrool commented Dec 12, 2021

@rambohe-ch
It seems no problem. I followed the step in #562, running kubectl exec into the pod called sonobuoy-e2e-job-cb02e5e67e844d4f. Here's the log.
image

As mentioned in the #562, the problem has been solved by #560.

@rambohe-ch
Copy link
Member

/hold cancel

@openyurt-bot openyurt-bot removed the do-not-merge/hold do-not-merge/hold label Dec 12, 2021
@rambohe-ch
Copy link
Member

@Congrool This issue #638 is also solved. @DrmagicE

@rambohe-ch
Copy link
Member

@DrmagicE Do you have any comments about this pull request?

go.sum Show resolved Hide resolved
@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Dec 12, 2021
@Congrool Congrool changed the title [enhancement] enable yurthub to handle upgrade request [enhancement] [WIP] enable yurthub to handle upgrade request Dec 12, 2021
@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Dec 12, 2021
@Congrool Congrool changed the title [enhancement] [WIP] enable yurthub to handle upgrade request [WIP] [enhancement] enable yurthub to handle upgrade request Dec 12, 2021
@openyurt-bot openyurt-bot added the do-not-merge/work-in-progress do-not-merge/work-in-progress label Dec 12, 2021
@Congrool Congrool changed the title [WIP] [enhancement] enable yurthub to handle upgrade request [enhancement] enable yurthub to handle upgrade request Dec 12, 2021
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Dec 12, 2021
@DrmagicE
Copy link
Member

/lgtm

MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Problems for Kubernetes Conformance
4 participants