-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge endpoints filter into service topology filter #963
merge endpoints filter into service topology filter #963
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer, zzguang. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
==========================================
+ Coverage 43.59% 44.05% +0.46%
==========================================
Files 83 83
Lines 11260 11346 +86
==========================================
+ Hits 4909 4999 +90
+ Misses 5914 5912 -2
+ Partials 437 435 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/assign @zzguang |
@rambohe-ch: GitHub didn't allow me to assign the following users: zzguang. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@zzguang: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
merge endpoints filter into service topology filter, so service topology feature can have the same ability for all kinds of clients.
Which issue(s) this PR fixes:
Fixes #954
Special notes for your reviewer:
/assign @zzguang
Does this PR introduce a user-facing change?
other Note