-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test cases for yurthub #972
test: add test cases for yurthub #972
Conversation
@donychen1134: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
==========================================
+ Coverage 44.38% 45.22% +0.83%
==========================================
Files 83 85 +2
Lines 11370 11857 +487
==========================================
+ Hits 5047 5362 +315
- Misses 5886 6047 +161
- Partials 437 448 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@donychen1134 please fix the golangci-lint errors. the library import sequence:
|
pkg/util/kubernetes/kubeadm/app/util/initsystem/initsystem_unix.go
Outdated
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: donychen1134, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
add unit test cases for yurthub
Which issue(s) this PR fixes:
Fixes #917
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note