This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Fix HAVE_MUTEX_OWNER test for kernels prior to 4.6 #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent 4.X kernels prior to 4.6 require #include of spinlock.h in order to get the definition of __ARCH_SPIN_LOCK_UNLOCKED which isused by DEFINE_MUTEX().
|
Sorry, but I've not figured out which kernel commit prior to 4.6 obviates the need for |
|
Interesting find, well even if we can't pin it down to a specific commit adding the additional include is safe and probably a good idea. |
nedbass
pushed a commit
to nedbass/spl
that referenced
this pull request
Aug 26, 2016
Recent 4.X kernels prior to 4.6 require #include of spinlock.h in order to get the definition of __ARCH_SPIN_LOCK_UNLOCKED which is used by DEFINE_MUTEX(). Signed-off-by: Tim Chase <tim@chase2k.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#566
tuxoko
pushed a commit
to tuxoko/spl
that referenced
this pull request
Sep 8, 2016
Recent 4.X kernels prior to 4.6 require #include of spinlock.h in order to get the definition of __ARCH_SPIN_LOCK_UNLOCKED which is used by DEFINE_MUTEX(). Signed-off-by: Tim Chase <tim@chase2k.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#566
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent 4.X kernels prior to 4.6 require #include of spinlock.h in
order to get the definition of __ARCH_SPIN_LOCK_UNLOCKED which is used
by DEFINE_MUTEX().
[EDIT: missing space in commit comment fixed but not yet committed/pushed]