Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify content header length #321

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

Fix #320

To be reviewed / merged after #319

@benoit74 benoit74 self-assigned this Jun 17, 2024
@benoit74 benoit74 marked this pull request as ready for review June 18, 2024 12:01
@benoit74 benoit74 requested a review from rgaudin June 18, 2024 12:01
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (8f79546) to head (f8fe4bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   84.57%   84.61%   +0.03%     
==========================================
  Files          14       14              
  Lines        1245     1248       +3     
  Branches      246      246              
==========================================
+ Hits         1053     1056       +3     
  Misses        149      149              
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but what I don't like here is that it's a magic option. There's no information about when this should be changed, why and how to figure out a better value.

@benoit74
Copy link
Collaborator Author

It's definitely kind of an expert value. But needs to be exposed in the Zimfarm so that it can be tweaked when needed.

@benoit74 benoit74 merged commit 06c1da7 into main Jun 18, 2024
7 checks passed
@benoit74 benoit74 deleted the content_header_length branch June 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to specify how characters to consider when searching charset in content header
2 participants