Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fuzzy rules tests #348

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Generate fuzzy rules tests #348

merged 2 commits into from
Jul 30, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #284

Changes:

  • fuzzy rules defined in YAML must now have a name and a tests properties
  • tests in Python and in Javascript are automatically generated from YAML thanks to these two properties
  • one rule (vimeo_cdn_fix) needed to be fixed because tests showed that it was not working as intended in JS

@benoit74 benoit74 self-assigned this Jul 17, 2024
@benoit74 benoit74 marked this pull request as ready for review July 17, 2024 08:13
@benoit74 benoit74 requested a review from rgaudin July 17, 2024 08:13
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rules/generate_rules.py Outdated Show resolved Hide resolved
@benoit74 benoit74 merged commit deb7df6 into main Jul 30, 2024
5 checks passed
@benoit74 benoit74 deleted the generate_fuzzy_tests branch July 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share FuzzyRules test data between JS and Python
2 participants