-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collections and temporary directory parameters #254
Conversation
b8cb755
to
a2b4c71
Compare
@rgaudin @kelson42 I finally slightly changed my opinion compared to Tuesday discussion, I fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but there are some naming to fix
…ix data / cleanup correctly afer run
Thank you, I also fixed a "bug" where I did not created one temporary subdir per run, which I found problematic in terms of data segregation and very/risky for the cleanup which was deleting the whole build dir while it might have contained other files before the run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Rationale
--collection
CLI argument #252Changes
--collection
parameter is now used correctly to find WARC files--build
parameter (optional) to place Browsertrix files in a different directory that ZIM files--output
directory--build
(if supplied) or--output
by defaultwarc2zim
arguments