Updates to latest docker images, aligning maven version #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
codefromthecrypt
force-pushed
the
docker
branch
from
da192af to
74d67ed
Compare
codefromthecrypt
commented
Aug 3, 2024
| @@ -58,7 +58,7 @@ fi | |||
|
|
|||
| if ! test -f ${artifact_id}.jar && [ ${is_release} = "true" ]; then | |||
| mvn_get="mvn -q --batch-mode -Denforcer.fail=false \ | |||
| org.apache.maven.plugins:maven-dependency-plugin:3.6.1:get \ | |||
| org.apache.maven.plugins:maven-dependency-plugin:3.7.1:get \ | |||
There was a problem hiding this comment.
here we make sure we use the same version cached in the java images
| @@ -45,8 +45,8 @@ | |||
| <go-offline-maven-plugin.version>1.2.8</go-offline-maven-plugin.version> | |||
| <maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version> | |||
| <!-- Use same version as https://github.com/openzipkin/docker-java --> | |||
| <maven-dependency-plugin.version>3.6.1</maven-dependency-plugin.version> | |||
| <maven-help-plugin.version>3.4.0</maven-help-plugin.version> | |||
| <maven-dependency-plugin.version>3.7.1</maven-dependency-plugin.version> | |||
There was a problem hiding this comment.
here also, we make sure we use the same version cached in the java images
| @@ -8,38 +8,38 @@ else | |||
| exit 1 | |||
| fi | |||
|
|
|||
| JAVA_VERSION=${JAVA_VERSION:-21.0.3_p9} | |||
| JAVA_VERSION=${JAVA_VERSION:-21.0.4_p7} | |||
There was a problem hiding this comment.
all images here are newly published, except the jdk 1.6 which has no update in recent years
|
ps this same change needs to happen on zipkin, -aws and -gcp, but testing it here first. (works or you would see failed tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses latest java images, and aligns with the following tools provided by them:
To align, we run "mvn wrapper:wrapper -Dtype=bin" to update maven and manually change any pom or script references to share the above plugin versions.
Besides text replacement for current java versions, this also had to switch
docker-composetodocker composeas the former is no longer in the base image.This intentionally doesn't touch anything else, or maven plugins that aren't cached in the java image.