moves off deprecated error code in dubbo

Signed-off-by: Adrian Cole <adrian@tetrate.io>
openzipkin · Jan 6, 2024 · 6fdf49c · 6fdf49c
1 parent e250f09
commit 6fdf49c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/instrumentation/dubbo-rpc/src/test/java/brave/dubbo/rpc/ITTracingFilter_Consumer.java b/instrumentation/dubbo-rpc/src/test/java/brave/dubbo/rpc/ITTracingFilter_Consumer.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2013-2023 The OpenZipkin Authors
+ * Copyright 2013-2024 The OpenZipkin Authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
@@ -205,7 +205,7 @@ class ITTracingFilter_Consumer extends ITTracingFilter {
     MutableSpan span =
         testSpanHandler.takeRemoteSpanWithErrorMessage(CLIENT, ".*Not found exported service.*");
     assertThat(span.tags())
-        .containsEntry("dubbo.error_code", "1");
+        .containsEntry("rpc.error_code", "NETWORK_EXCEPTION");
   }
 
   /** Shows if you aren't using RpcTracing, the old "dubbo.error_code" works */

diff --git a/instrumentation/dubbo/src/test/java/brave/dubbo/ITTracingFilter_Consumer.java b/instrumentation/dubbo/src/test/java/brave/dubbo/ITTracingFilter_Consumer.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2013-2023 The OpenZipkin Authors
+ * Copyright 2013-2024 The OpenZipkin Authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
@@ -236,7 +236,7 @@ class ITTracingFilter_Consumer extends ITTracingFilter {
         testSpanHandler.takeRemoteSpanWithErrorMessage(CLIENT, ".*Fail to decode request.*");
 
     assertThat(span.tags())
-        .containsEntry("dubbo.error_code", "1");
+        .containsEntry("rpc.error_code", "NETWORK_EXCEPTION");
   }
 
   /** Shows if you aren't using RpcTracing, the old "dubbo.error_code" works */