Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes race condition with toSpan and flush #1306

Closed
wants to merge 3 commits into from
Closed

Fixes race condition with toSpan and flush #1306

wants to merge 3 commits into from

Commits on Dec 15, 2023

  1. Fixes race condition with toSpan and flush 

    Fixes openzipkin#1295
Previous to this fix, a call to Tracer::toSpan concurrent with a call
to flush the span from pendingSpans could result in an assertion error.

We now only fetch the pendingSpan once for a single call to toSpan.
    @alintnersfdc
    alintnersfdc authored and Adrian Cole committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3536934 View commit details
    Browse the repository at this point in the history

  2. Address review feedback

    @alintnersfdc
    alintnersfdc authored and Adrian Cole committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c1b7446 View commit details
    Browse the repository at this point in the history

  3. licens 

    Signed-off-by: Adrian Cole <adrian@tetrate.io>
    Adrian Cole committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    42a8705 View commit details
    Browse the repository at this point in the history