Undeprecates propagation symbols for v6 interop #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2024
codefromthecrypt
pushed a commit
to openzipkin/zipkin-aws
that referenced
this pull request
Jan 7, 2024
See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
pushed a commit
to openzipkin/zipkin-gcp
that referenced
this pull request
Jan 7, 2024
See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
This was referenced Jan 7, 2024
codefromthecrypt
pushed a commit
to codefromthecrypt/tracing
that referenced
this pull request
Jan 7, 2024
This updates to Brave 5.17.1 and dodges an internal type that will not be in Brave 6.0. See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
pushed a commit
to codefromthecrypt/spring-cloud-sleuth
that referenced
this pull request
Jan 7, 2024
This updates to Brave 5.17.1 and dodges an internal type that will not be in Brave 6.0. See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
This undeprecates B3SinglePropagation and enforces at runtime that `Propagation.Factory#get()` must be implemented. I spot checked all the implementations on GitHub already do. Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
undeprecate
branch
from
d7b7fc7
to
fa43521
Compare
codefromthecrypt
pushed a commit
to codefromthecrypt/spring-boot
that referenced
this pull request
Jan 7, 2024
This updates to Brave 5.17.1 and dodges an internal type that will not be in Brave 6.0. See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
pushed a commit
to codefromthecrypt/noticeBoard
that referenced
this pull request
Jan 7, 2024
This dodges an internal type that will not be in Brave 6.0. See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
This was referenced Jan 7, 2024
|
ok I scraped github and raised PRs for all the known implementations of propagation. Most were things I did or copies of stuff @marcingrzejszczak made cc @shakuzen After those projects merge, they will be safe to update into Brave 6 (#1395) |
codefromthecrypt
commented
Jan 7, 2024
| @@ -70,7 +70,10 @@ | |||
| * }</pre> | |||
| * | |||
| * @since 5.12 | |||
| * @deprecated As of Brave 5.18, throw an {@link UnsupportedOperationException} in | |||
There was a problem hiding this comment.
this is internal, but I put a deprecated message on it anyway as many have been using it without shading. The pull requests I mentioned move off it.
|
Also, all PRs I mentioned on this issue are opened to allow editors to write to my branch. Not saying they will, but they can as necessary. |
|
I also released this to maven central as it seems there are a couple copies of brave w3c tracecontext (even if not the same impl as the one I wrote) https://central.sonatype.com/artifact/io.zipkin.contrib.brave-propagation-w3c/brave-propagation-tracecontext/versions https://github.com/openzipkin-contrib/brave-propagation-w3c |
reta
approved these changes
Jan 7, 2024
codefromthecrypt
added a commit
to openzipkin/zipkin-aws
that referenced
this pull request
Jan 7, 2024
See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
added a commit
to openzipkin/zipkin-gcp
that referenced
this pull request
Jan 7, 2024
See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <adrian@tetrate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undeprecates B3SinglePropagation and enforces at runtime that
Propagation.Factory#get()must be implemented. I spot checked all the implementations on GitHub already do.