Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes thread safety issue in Tag.tag #1434

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fixes thread safety issue in Tag.tag #1434

merged 1 commit into from
Apr 11, 2024

Commits on Apr 10, 2024

  1. Fixes thread safety issue in Tag.tag 

    The current codebase carefully synchronizes all access to MutableSpan
where there can be concurrent use. We missed a spot where Tag.tag is not
synchronizing access. The only other place we don't guard is ScopedSpan,
which is documented explicitly as not thread safe.

Fixes #1384

Signed-off-by: Adrian Cole <adrian@tetrate.io>
    Adrian Cole committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4fe789a View commit details
    Browse the repository at this point in the history