Let client override the service name #19
Conversation
When submitting and Endpoint, Zipkin expects the client to submit its own host and port, but the service name of the service it's calling. This commit adds a method to ClientTracer that lets you specify the name of the service you're calling. If no service name is specified, Brave will fallback to using the server's service name when submitting the Endpoint.
|
See the commit message for more info. |
|
Thanks Eirik. I'll probably only come to review this in detail next week. |
|
I did a test and indeed the service name for the end points at client and server side should be the same. This makes the traces easier to read in zipkin-web and also the duration calculation makes more sense. The ip addresses can remain as they are so we can see origin and destination for span. Your changes look good, I'll merge PR and adapt the rest-easy and apache http client integration code. Thanks! |
Let client override the service name. This allows setting endpoint service name at client and server the same which results in better readable traces in zipkin-web.
|
Does this mean that it's not fixed in brave-jersey? |
|
Yes that's right. brave-jersey is not adapted :( |
This is a consequence of https://groups.google.com/forum/#!topic/zipkin-user/Q_EZp3pQXk4 and #18.