Begins work to bridge from alibaba to apache dubbo #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
codefromthecrypt
commented
Jul 4, 2019
| * injected. | ||
| * <h3>Notes for com.alibaba:dubbo</h3> | ||
| * | ||
| * {@code com.alibaba.dubbo.common.extension.ExtensionLoader} supplies the tracing implementation |
There was a problem hiding this comment.
TODO: I think maybe we can just say the word ExtensionLoader and SpringExtensionFactory here and leave out the package name as they likely exist. We should also check the README for drift
added 2 commits
August 11, 2019 19:59
Starting with the 2.7.3 all of our main code can compile with org.apache.dubbo:dubbo and also com.alibaba:dubbo There is some strange work here because the spring integrations were not backported. Until such time as it is, we need reflection to actually load the extensions. As this is fragile, this change shouldn't merge until a maven invoker test is setup to prove the tests also pass with com.alibaba:dubbo still. Also, we need to cleanup documentation around spring as it will mention types that don't exist. Fixes #867
codefromthecrypt
force-pushed
the
alibaba-to-apache
branch
from
bed12ab
to
13e4b91
Compare
|
this is still broken, and I've put a suggestion to give up on #867. idea is to close this PR and leave brave-instrumentation-dubbo-rpc pinned to alibaba dubbo. make a new brave-instrumentation-dubbo that is compatible with apache dubbo. That way we don't break binary compatibility here which would surprise people. Also, this acknowledges that eventhough we tried it is too much effort attempting a bridge, and it always leads to nothing. By making a new module at least new people can use it. cc @openzipkin/brave |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with the 2.7.3 all of our main code can compile with
org.apache.dubbo:dubbo and also com.alibaba:dubbo
There is some strange work here because the spring integrations were not
backported. Until such time as it is, we need reflection to actually
load the extensions. As this is fragile, this change shouldn't merge
until a maven invoker test is setup to prove the tests also pass with
com.alibaba:dubbo still. Also, we need to cleanup documentation around
spring as it will mention types that don't exist.
Fixes #867