-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update infra and dependencies #232
Conversation
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Bumps the version of the Zipkin Docker Java image and OS used by GH Action runners and applies the same conventions to Dockerfile. Fixes the trivy intermittent issue; See aquasecurity/trivy#7668
0680326
to
46a4266
Compare
I'm not sure what is wrong with the lint check. I've finally got the security check passing by upgrading everything, but unfortunately it causes the collector-pubsub module tests to fail. I am out of time to look into it today, but I was having trouble figuring out where the issue was; it does appear to be caused by bumping the pubsub dependencies, though. |
I think I finally got the underlying exception:
Which I've traced back to this change googleapis/java-pubsub@db522b6. While I don't think that change should have broke this test, certainly not in the way that it did, it does appear we're using the wrong format for the subscription name in the collector-pubsub test. The build passes once fixing that. |
A feature added in the client now validates the subscription name format when dispatching messages as a side effect, even if that feature isn't enabled. Uses a correctly formatted subscription name in the test.
It looks like the lint failure is probably this issue: tcort/markdown-link-check#369 |
Nothing has changed in any of the markdown with this PR, so I think we can ignore the lint failure in this case. Merging. |
Added some work to #231