Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we record http.request.size when in GET or when it is 0? #80

Closed
jcchavezs opened this issue Sep 25, 2018 · 3 comments
Closed

Should we record http.request.size when in GET or when it is 0? #80

jcchavezs opened this issue Sep 25, 2018 · 3 comments
Assignees
@jcchavezs

Comments

@jcchavezs
Copy link
Contributor

Lately I saw many traces including the http.request.size=0 in some server spans and I am thinking this is just adding buzz when it comes to GET requests or when the value is zero. What do you think?

cc @adriancole @basvanbeek
@basvanbeek
Copy link
Member

I think we should omit as it's just added noise this way

@jcchavezs
Copy link
Contributor Author

@basvanbeek I can come up with a PR for this.

jcchavezs added a commit that referenced this issue Sep 25, 2018
@jcchavezs
fix(#80): removes http.request.size when request body is empty or mis…
eb95837 
…sing.
@ghost ghost assigned jcchavezs Sep 25, 2018
@ghost ghost added the in progress label Sep 25, 2018
@jcchavezs jcchavezs mentioned this issue Sep 25, 2018
Merged
jcchavezs added a commit that referenced this issue Sep 27, 2018
@jcchavezs
Merge pull request #81 from openzipkin/80_removes_request_size_on_empty
1cbef8b 
fix(#80): removes http.request.size when request body is empty or missing
jcchavezs added a commit that referenced this issue Sep 27, 2018
@jcchavezs
fix(#80): removes http.response.size when response body is empty.
ebf7ad5
@jcchavezs jcchavezs mentioned this issue Sep 27, 2018
Merged
jcchavezs added a commit that referenced this issue Sep 27, 2018
@jcchavezs
Merge pull request #82 from openzipkin/80_removes_response_size_on_empty
70244c9 
fix(#80): removes http.response.size when response body is empty.
@jcchavezs
Copy link
Contributor Author

Closed by #81 and #82

@ghost ghost removed the in progress label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcchavezs jcchavezs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcchavezs @basvanbeek