Adds SpanOrNoopFromContext convenience function #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@romaindoumenc would this work for you? |
1 similar comment
Yep, and I like the documentation. Pretty sure you already thought about it, using a dedicated function makes it easy to see the progress of the conversion to Zipkin. So 👏 |
There was a problem hiding this comment.
glad to see this. if people are switching between java and go, this is similar in nature to what's served by Brave's CurrentSpanCustomizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves concerns as expressed in: #97
This typically is used in modular code where it is not guaranteed that spans are propagated in the resulting application binary. For this code it is advisable to test for nil but for those dead set on tracing API's having zero side effects this solves that issue.