go.mod: update grpc from v1.16.0 to v1.17.0

[dmitshur]

Update the grpc dependency to v1.17.0, which includes the fix
to remove the invalid github.com/golang/lint module requirement
in grpc/grpc-go#2393.

Additionally, the currently specified pseudo-version of the genproto module,
which is v0.0.0-20181109154231-b5d43981345b, itself requires grpc v1.16.0.

Drop this indirect requirement, since it's not needed for the purposes
of the main zipkin-go module.

This change was generated by running the following commands
using Go 1.2:

go get google.golang.org/grpc@v1.17.0
go mod edit -droprequire=google.golang.org/genproto
go mod tidy

Fixes #114
Updates golang/lint#436

[coveralls]

Coverage remained the same at 66.25% when pulling fd2c0fa on dmitshur:update-grpc into 62dc8b2 on openzipkin:master.

[jcchavezs]

Thanks for this @dmitshur. Is there a way we also make this fail in CI so we avoid further conflicts in future versions? Den tor. 28. feb. 2019, 05:52 skrev thepudds <notifications@github.com>:

…

***@***.**** commented on this pull request. ------------------------------ In go.mod <#115 (comment)>: > @@ -20,5 +20,5 @@ require ( golang.org/x/sync v0.0.0-20181108010431-42b317875d0f // indirect golang.org/x/sys v0.0.0-20181122145206-62eef0e2fa9b // indirect google.golang.org/genproto v0.0.0-20181109154231-b5d43981345b // indirect OK, looks removing genproto from the go.mod here would in effect downgrade genproto here from a November 2018 commit (20181109154231) to an August 2018 commit (20180817151627). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#115 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7sAo1FLg1WOE8EAxxU7G6VV6U6VIwaks5vR2CYgaJpZM4bV8lc> .

[dmitshur]

Are you asking if it’s possible to detect an issue like #114 in CI? I’m not sure right now, but I’ll think more about it.

An initial idea is to have a script that creates an empty module and does go get -u github.com/openzipkin/zipkin-go in it. But I recommend thinking more about the implications of doing this (in a separate issue) before committing to it.

[jcchavezs]

Sounds reasonable. I will create an issue for this. Den tor. 28. feb. 2019, 08:01 skrev Dmitri Shuralyov < notifications@github.com>:

…

Are you asking if it’s possible to detect an issue like #114 <#114> in CI? I’m not sure right now, but I’ll think more about it. An initial idea is to have a script that creates an empty module and does go get -u github.com/openzipkin/zipkin-go in it. But I recommend thinking more about the implications of doing this (in a separate issue) before committing to it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#115 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7sAqxAC3G2AOKxKmHAf-Jj_YbYJzCuks5vR37NgaJpZM4bV8lc> .

[dmitshur]

Sounds good.

Is there anything you need from me to make progress on this PR?

To clarify, this is ready from my side.

[jcchavezs]

@basvanbeek do you have any input on this? Otherwise I will just merge it.

[basvanbeek]

Thanks @dmitshur for the PR and thanks @jcchavezs for helping out here.

[dmitshur]

No problem!

Just checking, are you planning on making a new release? Issue #114 is not yet fully resolved until this change is included in the latest released tag. The current latest v0.1.5 doesn't include this change yet.

[dmitshur]

I've filed issue #117 about making a new tag.