add ability to serialize/deserialize b3 to Go map[string]string #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Aug 30, 2019
propagation/b3/map_test.go
Outdated
| func TestMapExtractTraceIDError(t *testing.T) { | ||
| m := make(b3.Map) | ||
|
|
||
| m[b3.TraceID] = "invalid_data" |
There was a problem hiding this comment.
string invalid_data has 4 occurrences, make it a constant (from goconst)
There was a problem hiding this comment.
I wish this would be squelched for *_test packages
|
This also allows for keeping B3 logic separated from OpenTracing... a PR for our OpenTracing Go bridge will follow on that repo. |
devinsba
reviewed
Aug 30, 2019
|
|
||
| if want, have := false, *sc.Sampled; want != have { | ||
| t.Errorf("Sampled want %t, have %t", want, have) | ||
| } |
There was a problem hiding this comment.
Just a comment, I'm surprised that go doesn't include matchers in the standard library test utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows proper B3 serialization / deserialization logic on a generic Go map[string]string storage.
This allows for easy B3 plugability when dealing with non natively supported header containers.