HTTPReporter: Adds b3:0 header and unit test for custom headers using HTTPDoer #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
approved these changes
Sep 9, 2020
codefromthecrypt
pushed a commit
to openzipkin/zipkin-reporter-java
that referenced
this pull request
Sep 10, 2020
codefromthecrypt
pushed a commit
to openzipkin/zipkin-reporter-java
that referenced
this pull request
Sep 10, 2020
|
I am wonder if we should be supporting the option `AllowSamplingReporterCalls` for not including B3 header. Brave
does not and frankly I'd not support the option until someone really wants
to trace the reporting call. What do you think @basvanbeek?
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mitigate trace amplification in service mesh environments we default to sending a
B3: 0header to our outgoing OOB calls to the Zipkin collector.To allow these calls still to be traced by a sidecar, this now default behavior can be reverted using the
AllowSamplingReporterCallsfunctional option.There is sometimes a need to inject custom headers as well. We had the support through the HTTPDoer interface but did not test for this functionality to work. This PR adds a unit test for it as well as show how to use HTTPDoer for this feature.