Add support for Go Modules #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.11 adds support for modules, which allow building outside of a
GOPATH. This makes it much easier to contribute to golang repositories.Confirmed that
make testworks in the repo in a random location on the filesystem.Also went ahead and enabled modules on appveyor build. It seems the appveyor build has been failing for some time because
go get ...tends to bring in bogus transitive dependencies, and one of them requiresgcc. I guess stable builds require either go modules orgo vendor. Enabling modules fixes the appveyor build.