Backfill ts tests for actual implementations.

[jcchavezs]

After #264 was merged now we have a way to test implementation to fulfill TS signature. What is missing now is to backfill tests for all packages.

Ping @sonybinhle

[sonybinhle]

@jcchavezs Could you please assign this issue to me?

What is the standard PR styles in our project?
For example, I prefer to write the test for about 10 functions at once and file by file.
I mean if I create the PR for this issue, I will divide it into multiple small PRs.

[codefromthecrypt]

usually we do a PR per task not per file. if all the changes are related I would raise one pr

…

On Tue, 9 Oct 2018, 04:48 Binh Le, ***@***.***> wrote: @jcchavezs <https://github.com/jcchavezs> Could you please assign this issue to me? What is the standard PR styles in our project? For example, I prefer to write the test for about 10 functions at once and file by file. I mean if I create the PR for this issue, I will divide it into multiple small PRs. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#268 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD61_Z2c1T_ruQZCtBtmddsyD6X4Cyiks5ui7oCgaJpZM4XMgsq> .

[jcchavezs]

@sonybinhle I kind of see your point but what I believe you meant is one PR per package (because hapilly an index.d.ts matches with one package). I am OK with you doing it per package as it will be easy to review an merge.

[sonybinhle]

@adriancole @jcchavezs Thank you very much, so I will raise the PRs per package.