Backfills integrated tests of BatchRecorder #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2019 18:31
There were some red herrings about an example failing. This carves out a unit test for people to fill for suspected problems.
| }); | ||
|
|
||
| it('should start and finish a consumer span', () => { | ||
| recorder.record(new Record({traceId, annotation: new Annotation.ConsumerStart()})); |
There was a problem hiding this comment.
one thing I've struggled to assert is that recorder.partialSpans should have contents at this point. I can't get a chai assertion to show it.
This was referenced Jun 6, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some red herrings about an example failing. This carves out
a unit test for people to fill for suspected problems.