fix: fixes undefined comparison and partial span timeout rules. #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
commented
Oct 14, 2019
| tracer.letId(id, () => { | ||
| // if route is terminated on middleware req.route won't be available | ||
| const route = req.route && req.route.path; | ||
| tracer.recordRpc(instrumentation.spanNameFromRoute(req.method, route, res.statusCode)); |
There was a problem hiding this comment.
we are sure this is being reached, otherwise the integration test suite for httpserver will fail due to span naming.
jcchavezs
commented
Oct 14, 2019
| // TODO(adriancole) refactor so this responsibility isn't in writeSpan | ||
| if (!isNew && this.partialSpans.get(id) === 'undefined') { | ||
| // Span not found. Could have been expired. | ||
| if (!isNew && typeof this.partialSpans.get(id) === 'undefined') { |
There was a problem hiding this comment.
In the end we did not need the parenthesis @adriancole
jcchavezs
commented
Oct 14, 2019
| } | ||
| }; | ||
| recorder._writeSpan(rootId, span); | ||
| expect(spans).to.be.empty; // eslint-disable-line no-unused-expressions |
There was a problem hiding this comment.
This test makes sure this is right: https://github.com/openzipkin/zipkin-js/pull/449/files#diff-503c850b99353bea68792242ff75f9edR114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a comparison with
undefinedand also adds a guard forpartial spansthat have nottimestampattribute (because they were already reported).Ping @adriancole