Temporarily prefers gRPC's guava #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This temporarily prefers gRPC 0.19's guava while we figure out what better options exist. Cassandra is recently flexible wrt guava version. gRPC, used by zipkin-gcp is the least flexible in dependencies. Likley, we will port that project to direct use of armeria to lower the push and pull.
codefromthecrypt
force-pushed
the
guava-up
branch
from
ce8ff78
to
3a43995
Compare
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
This temporarily prefers gRPC 0.19's guava while we figure out what better options exist. Cassandra is recently flexible wrt guava version. gRPC, used by zipkin-gcp is the least flexible in dependencies. Likley, we will port that project to direct use of armeria to lower the push and pull.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporarily prefers gRPC 0.19's guava while we figure out what
better options exist. Cassandra is recently flexible wrt guava version.
gRPC, used by zipkin-gcp is the least flexible in dependencies. Likley,
we will port that project to direct use of armeria to lower the push
and pull.
maybe obviated with openzipkin/zipkin-gcp#119