Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2892

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Update dependencies #2892

merged 3 commits into from
Oct 29, 2019

Conversation

jeqo
Copy link
Member

@jeqo jeqo commented Oct 29, 2019

Update deps, mainly Armeria, in order to fix this

@anuraaga
Copy link
Contributor

There's a major breaking change in 0.95.0 for how annotated services are run https://github.com/line/armeria/releases/tag/armeria-0.95.0

We need to add @Blocking to all annotated services that don't return HttpResponse or CompletionStage - I think in this codebase, it's just the query API that returns AggregatedHttpResponse, also can't forget in the kafka code to add it to all the methods returning a JSON object.

pom.xml Outdated Show resolved Hide resolved
@codefromthecrypt codefromthecrypt merged commit 7d1f9ef into master Oct 29, 2019
@codefromthecrypt codefromthecrypt deleted the armeria-0.95 branch October 29, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants