Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

use src/s1_burst_id structure for python packaging #4

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

yunjunz
Copy link
Contributor

@yunjunz yunjunz commented Dec 1, 2021

This PR re-organizes the repo structure to the src/{module_name} style, as described in #2.

The detailed changes are:

  • move the following scripts under src/s1_burst_id as a python module:

    • BurstDataFrame.py
    • query.py
    • upload_data.py
  • move the following script to bin/ as executable scripts:

    • create_burst_id.py
    • chmod +x create_burst_id.py
  • add requirements.txt

  • add .gitignore file

  • remove __inti__.py

@yunjunz yunjunz requested a review from hfattahi December 1, 2021 22:48
@yunjunz yunjunz linked an issue Dec 1, 2021 that may be closed by this pull request
Copy link
Contributor

@hfattahi hfattahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks @yunjunz

@hfattahi
Copy link
Contributor

@LiangJYu @vbrancat @gshiroma could you take a look at this PR?

Copy link
Collaborator

@LiangJYu LiangJYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vbrancat vbrancat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

+ move the following scripts under src/s1_burst_id as a python module:
   - BurstDataFrame.py
   - query.py
   - upload_data.py

+ move the following script to bin/ as executable scripts:
   - create_burst_id.py
   - chmod +x create_burst_id.py

+ add requirements.txt

+ add .gitignore file

+ remove __inti__.py
@yunjunz yunjunz merged commit a42ab0a into opera-adt:main Dec 11, 2021
@yunjunz yunjunz deleted the src4module branch December 11, 2021 03:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repo code structure
4 participants