add missing comments for status fields #316
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 42.45% 42.45%
=======================================
Files 42 42
Lines 4011 4011
=======================================
Hits 1703 1703
Misses 2156 2156
Partials 152 152 ☔ View full report in Codecov by Sentry. |
grokspawn
force-pushed
the
catalogsource-status
branch
2 times, most recently
from
3f8d243
to
8ef2b3d
Compare
| GRPCConnectionState *GRPCConnectionState `json:"connectionState,omitempty"` | ||
| // ConfigMapReference (deprecated) is the reference to the ConfigMap containing the catalog source's configuration, when the catalog source is a ConfigMap | ||
| ConfigMapResource *ConfigMapResourceReference `json:"configMapReference,omitempty"` | ||
| // RegistryService is the GRPC service that the catalog source is using to serve the catalog |
There was a problem hiding this comment.
This comment doesn't actually describe the meaning of this field, it just describes what the field is describing
There was a problem hiding this comment.
Well, phooey. Thought I'd fixed that chatgpt'd fluff before I opened it. Updated now.
grokspawn
force-pushed
the
catalogsource-status
branch
from
8ef2b3d
to
c180dcf
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit bdb0455
into
operator-framework:master
solves #317