🐛 fix ClusterServiceVersion CRD Generation

[perdasilva]

New API updates is tripping up more validations against default values in the Deployment stanza of the CSV. This PR adds a couple of yq replacement queries to add default values to those fields.

seems the crds/zz_defs.go was also out of sync - regeneration seems to have fixed it

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.43%. Comparing base (7d638a0) to head (eb2af81).

❗ Current head eb2af81 differs from pull request most recent head 78fb217

Please upload reports for the commit 78fb217 to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   39.43%   39.43%           
=======================================
  Files          56       56           
  Lines        4516     4516           
=======================================
  Hits         1781     1781           
  Misses       2581     2581           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[m1kola]

It seems like crds/zz_defs.go needs make format

[perdasilva]

I think we can override the verify here. It seems like there's been a change in the go doc for json.RawMessage:

// RawMessage is a raw encoded JSON value.
// It implements [Marshaler] and [Unmarshaler] and can
// be used to delay JSON decoding or precompute a JSON encoding.
type RawMessage []byte

https://github.com/golang/go/blob/release-branch.go1.22/src/encoding/json/stream.go#L255

This is changing the field description and causing verify to fail

[perdasilva]

It seems like crds/zz_defs.go needs make format

Thank you! I was chasing a different issue. Let's see if verify clears it (it will fail for the reasons I stated above in olm)...

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1kola, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[m1kola]

/hold

Want to check one thing before we merge

[m1kola]

/unhold

[perdasilva]

/hold - let's see if the kind job in the other PR fails first - then merge, and see if it succeeds =D

[perdasilva]

/unhold