Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump k8s dependencies to 1.26.2 #211

Merged
merged 8 commits into from
Mar 7, 2023
Merged

bump k8s dependencies to 1.26.2 #211

merged 8 commits into from
Mar 7, 2023

Conversation

rashmigottipati
Copy link
Member

No description provided.

@rashmigottipati
Copy link
Member Author

/hold
while trying to figure out failing tests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2023
everettraven
everettraven approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM to enable k8s 1.26 support.

A general nit: I think we should investigate the deprecation notices from the lint check to see if there is an alternative we can change and do a little bit of future proofing for our next k8s bumps.

varshaprasad96
varshaprasad96 requested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rashmigottipati This doesn't seem to bump the scaffolding of the plugin. Would that be done as a follow up?

varshaprasad96
varshaprasad96 requested changes Mar 3, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@laxmikantbpandhare
Copy link
Member

Overall LGTM to enable k8s 1.26 support.

A general nit: I think we should investigate the deprecation notices from the lint check to see if there is an alternative we can change and do a little bit of future proofing for our next k8s bumps.

@rashmigottipati - deprecation errors, those functions completely removed or renamed in newer versions of k8s. We need to check and fix it before merging.

@laxmikantbpandhare laxmikantbpandhare mentioned this pull request Mar 5, 2023
Closed
13 tasks
@rashmigottipati rashmigottipati added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 5, 2023
@rashmigottipati rashmigottipati removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2023
rashmigottipati and others added 6 commits March 6, 2023 12:05
@rashmigottipati
bump k8s dependencies to 1.26.1
7e8ccf3 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati
Bump kubebuilder to v3.9.0
33e99a9 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati
Run make generate
3a78692 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati
Update k8s to 1.26.1 for testdata scaffolding
731e078 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@varshaprasad96 @rashmigottipati
fix linter errors
6e39e3a
@rashmigottipati
update go.mod and go.sum for test scaffolds
7d50c78 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@coveralls
Copy link

coveralls commented Mar 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4352492700

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.498%
Totals Coverage Status
Change from base Build 3877933874: 0.0%
Covered Lines: 1713
Relevant Lines: 1914
💛 - Coveralls

laxmikantbpandhare
laxmikantbpandhare approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks good to me

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@rashmigottipati
Copy link
Member Author

@varshaprasad96 @everettraven could you please review this PR again?

@rashmigottipati
Copy link
Member Author

Thanks to @varshaprasad96 for helping fix the lint errors!!!

grokspawn
grokspawn reviewed Mar 6, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
rashmigottipati
rashmigottipati commented Mar 6, 2023
View reviewed changes
Copy link
Member Author

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
until operator-framework/operator-lib#112 merges first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2023
rashmigottipati
rashmigottipati commented Mar 6, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@rashmigottipati
Update k8s dependencies from v0.26.1 to v0.26.2
00147bb 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@rashmigottipati rashmigottipati changed the title bump k8s dependencies to 1.26.1 bump k8s dependencies to 1.26.2 Mar 7, 2023
@rashmigottipati rashmigottipati removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2023
@rashmigottipati
Update operator-lib to point to latest commit
d9b8d23 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
everettraven
everettraven approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell all the changes look good. Thanks @rashmigottipati !

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
varshaprasad96
varshaprasad96 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@rashmigottipati rashmigottipati merged commit 6e30bde into operator-framework:main Mar 7, 2023
@rashmigottipati rashmigottipati deleted the k8sbump branch March 7, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laxmikantbpandhare laxmikantbpandhare laxmikantbpandhare approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@everettraven everettraven everettraven approved these changes

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees

@everettraven everettraven

@varshaprasad96 varshaprasad96

@laxmikantbpandhare laxmikantbpandhare

Labels
area/deps area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rashmigottipati @laxmikantbpandhare @coveralls @everettraven @varshaprasad96 @grokspawn