Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use patch without optimistic locking to remove finalizer #1235

Closed
wants to merge 5 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented May 24, 2022

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@csviri csviri marked this pull request as ready for review May 26, 2022 09:21
@csviri csviri requested a review from metacosm May 26, 2022 09:21
@csviri
Copy link
Collaborator Author

csviri commented May 26, 2022

@metacosm IMHO this is quite important feature, maybe release 3.1.0 or 3.0.2 with it? WDYT?

@csviri
Copy link
Collaborator Author

csviri commented May 27, 2022

This PR is replaced by: #1249

@csviri csviri closed this May 27, 2022
@metacosm
Copy link
Collaborator

Should we delete the associated branch if this work is replaced by another PR?

@csviri
Copy link
Collaborator Author

csviri commented May 30, 2022

yes I guess, will delete this.

@csviri csviri deleted the patch-for-remove-finalizer branch May 30, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use PATCH without optimistick locking to remove finalizer this way will avoid conflicts
2 participants