Adds Makefile for common dev tasks
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
m1kola
force-pushed
the
automation
branch
5 times, most recently
from
62a73b2
to
eaf9efb
Compare
m1kola
commented
Jul 31, 2023
| go-version-file: go.mod | ||
| cache-dependency-path: | | ||
| **/go.sum | ||
| .bingo/**.sum |
There was a problem hiding this comment.
Need to add this to other repos where we use bingo: this should speed up jobs significantly.
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
grokspawn
approved these changes
Jul 31, 2023
|
LGTM |
ncdc
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#305 updates the contribution guidelines based on changes in this PR.
This PR adds a
Makefilewith the following commands:make buildmake servemake lintIt also makes it easier to work with the local docs. E.g. we no longer need to ask contributors to go to the Hugo website and follow the instructions to install extended version of hugo:
Makefileand bingo do it for them.A list of prerequisites for local dev will be reduced to:
make build)make lint).