Update k8s dependencies to v0.28.5 #123
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage 80.99% 80.99%
=======================================
Files 17 17
Lines 484 484
=======================================
Hits 392 392
Misses 82 82
Partials 10 10 ☔ View full report in Codecov by Sentry. |
go.mod
Outdated
| k8s.io/client-go v0.27.2 | ||
| k8s.io/utils v0.0.0-20230220204549-a5ecb0141aa5 | ||
| sigs.k8s.io/controller-runtime v0.15.0 | ||
| k8s.io/api v0.28.4 |
There was a problem hiding this comment.
Could we bump all of the k8s.io versions to 0.28.5, since that is the most recent?
Neo2308
changed the title
go.mod
Outdated
| k8s.io/apiextensions-apiserver v0.28.4 // indirect | ||
| k8s.io/component-base v0.28.4 // indirect |
There was a problem hiding this comment.
Done!
Side-note: While in this case, there might not be an issue, I think the go best practice is to only update the direct dependencies and let the indirect dependencies resolve themselves (except if there is something very specific that we need). Updating the indirect dependencies manually can sometimes result in unexpected & weird behaviour.
Update k8s dependencies to v0.28.5
Update operator-framework/api dependency which has k8s 1.28 changes
Relates to: operator-framework/operator-sdk#6554