Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 bump kube to 0.31.0, controller-runtime to v0.19.0, and fix generics issues #192

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 27, 2024

Rebase of #186

Description of the change:
Bumps kube to v0.31.0 and controller-runtime to v0.19.0. Fixes deprecations and changes. Though, client-go has introduced some new interfaces and retired old ones. Hence, the API diff job failure.

Motivation for the change:
bring the library to the latest kube version

…s issues

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@tmshort tmshort requested a review from a team as a code owner August 27, 2024 20:33
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (c6f3cc0) to head (c0754d5).
Report is 1 commits behind head on main.

Files Patch % Lines
handler/pause.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   88.88%   88.86%   -0.02%     
==========================================
  Files          18       18              
  Lines         576      575       -1     
==========================================
- Hits          512      511       -1     
  Misses         51       51              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn added this pull request to the merge queue Aug 28, 2024
Merged via the queue into operator-framework:main with commit b6b2f1a Aug 28, 2024
4 of 6 checks passed
@tmshort tmshort deleted the bumpk8s branch August 28, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants