Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Total Test Number to report #1717

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add Total Test Number to report #1717

merged 1 commit into from
Aug 11, 2020

Conversation

Bowenislandsong
Copy link
Member

This commit adds the total number of test to report.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Add Total Test Number to report
0652f7f 
This commit adds the total number of test to report.
@Bowenislandsong
Copy link
Member Author

Bowenislandsong commented Aug 8, 2020 •
edited
Loading

This should be the follow-up PR for operator-framework/flake-analyzer#9 to enable total number test. This should merge because commenter should not comment if PR was successful. Also, this would upload all tests failed or successful.

totaltestcount: 20
failedtestcount: 19
...

This PR merges and then the total amount of test will catchup.

@Bowenislandsong
Copy link
Member Author

/cc @ecordell @benluddy

@Bowenislandsong
Copy link
Member Author

/retest

ecordell
ecordell approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bowenislandsong, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2020
@Bowenislandsong
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Bowenislandsong
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2bf9530 into operator-framework:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@benluddy benluddy Awaiting requested review from benluddy

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bowenislandsong @openshift-ci-robot @openshift-bot @ecordell @openshift-merge-robot